RE: [PATCH v5] can: xilinx CAN controller support.

[Appana Durga Kedareswara Rao]

Hi Marc,

> -----Original Message-----
> From: Michal Simek [mailto:monstr@xxxxxxxxx]
> Sent: Wednesday, March 12, 2014 3:32 PM
> To: Marc Kleine-Budde
> Cc: Appana Durga Kedareswara Rao; linux-can@xxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx;
> grant.likely@xxxxxxxxxx; Michal Simek; wg@xxxxxxxxxxxxxx;
> fengguang.wu@xxxxxxxxx
> Subject: Re: [PATCH v5] can: xilinx CAN controller support.
>
> On 03/11/2014 01:48 PM, Marc Kleine-Budde wrote:
> > On 03/11/2014 01:34 PM, Appana Durga Kedareswara Rao wrote:
> >
> >>>> diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig
> >>>> index
> >>>> 9e7d95d..b180239 100644
> >>>> --- a/drivers/net/can/Kconfig
> >>>> +++ b/drivers/net/can/Kconfig
> >>>> @@ -125,6 +125,13 @@ config CAN_GRCAN
> >>>>       endian syntheses of the cores would need some modifications on
> >>>>       the hardware level to work.
> >>>>
> >>>> +config CAN_XILINXCAN
> >>>> +   tristate "Xilinx CAN"
> >>>> +   depends on ARCH_ZYNQ || MICROBLAZE
> >>>
> >>> Is Zynq multiarch already?
> >> Discussions are going on this
> >> So the final thing that Fengguang ( fengguang.wu@xxxxxxxxx) Proposed
> >> is
> >>         config CAN_XILINX
> >>         tristate "Xilinx CAN"
> >>         depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST
> >>         depends on COMMON_CLK && HAS_MMIO  # whatever you need for
> >> other architectures
> >
> >> Are you Ok for this?
> >
> > You have to fill the 2nd depends on with some sane values, though.
>
> This should be that one
> config CAN_XILINX
>          tristate "Xilinx CAN"
>          depends on ARCH_ZYNQ || MICROBLAZE || COMPILE_TEST
>          depends on COMMON_CLK && HAS_IOMEM
>
>
> Is there any driver which is in CAN which not use MMIO accesses?
> If not, maybe we should just add dependency to



Can you please comment on this?
I had update driver with all the other comments I had a little confusion regarding
Which Kconfig options I need to use.

Regards,
Kedar.


> Thanks,
> Michal
>
>
>
> --
> Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
> w: www.monstr.eu p: +42-0-721842854
> Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
> Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-
> BOOT custodian and responsible for u-boot arm zynq platform
>



This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.