Re: Stricter module param and sysfs permission checks

[Alexey Dobriyan]

On Thu, Mar 20, 2014 at 7:27 AM, Dave Jones <davej@xxxxxxxxxx> wrote:
> On Thu, Mar 20, 2014 at 01:43:44PM +1030, Rusty Russell wrote:
>
>  > drivers/mtd/devices/docg3.c:
>  >      __ATTR(f##id##_dps0_protection_key, S_IWUGO, NULL, dps0_insert_key), \
>  >      __ATTR(f##id##_dps1_protection_key, S_IWUGO, NULL, dps1_insert_key), \
>  >
>  > drivers/scsi/pm8001/pm8001_ctl.c:
>  > static DEVICE_ATTR(update_fw, S_IRUGO|S_IWUGO,
>  >      pm8001_show_update_fw, pm8001_store_update_fw);
>
> Why on earth are these world writable ?

Yup.

I like new and improved checks.
Rusty, add my "& 2" check everywhere!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/