RE: [PATCH] usb: gadget: fsl: Add FSL USB Gadget entry in platform device id

From: suresh.gupta@xxxxxxxxxxxxx
Date: Thu Mar 20 2014 - 11:02:21 EST


> > > > > @@ -2654,6 +2654,8 @@ static const struct platform_device_id
> > > fsl_udc_devtype[] = {
> > > > > }, {
> > > > > .name = "imx-udc-mx51",
> > > > > }, {
> > > > > + .name = "fsl-usb2-udc",
> > > >
> > > > why aren't you just using chipidea ?
> > > > [SuresH] This is our legacy driver for all previous and existing
> > > > ppc socs. Many of our customers are already using this, and we
> > > > need to support them on this driver. We do have plans to shift to
> > > > chipidea, but after some time.
> > >
> > > cool, you already have plans, so we will see a new glue layer for
> > > v3.16 right ? Which means I don't need to take this patch either.
> > >
> > we do have plans, but in remote future. Right now, we need to support
> > customers on the present legacy driver. We'll phase out this driver
> > slowly when we integrate chipidea. At this time I would request you to
> > please accept this patch
>
> Even if Felipe takes the patch, I'll reject it as you should be doing the
> correct thing here, and if it's accepted, it will never be changed...

Hi Greg, I agree that moving to the chipidea driver is the right thing to do.
However, does this mean that companies have to phase out their current legacy
drivers as soon as a new controller specific driver is introduced in kernel ??
Can't they decide their own schedule based on their own requirements. Our only
concern is to keep supporting our customers till we move to the new driver.
I would really appreciate if you could accept this as this would give us
some time to move to chipidea driver.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/