Re: [PATCH] mfd: kempld-core: Fix potential hang-up during boot

From: Lee Jones
Date: Thu Mar 20 2014 - 11:49:56 EST


> > > On PXT and COMe-cPC2 boards it is observed that the hardware
> > > mutex is acquired but not being released during initialization.
> > > This can result in a hang-up during boot if the driver is built
> > > into the kernel.
> > >
> > > Releasing the mutex twice if it was acquired fixes the problem.
> > > Subsequent request/release cycles work as expected, so the fix is
> > > only needed during initialization.
> > >
> > > Reviewed-by: Michael Brunner <michael.brunner@xxxxxxxxxxx>
> > > Tested-by: Michael Brunner <michael.brunner@xxxxxxxxxxx>
> > > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > > ---
> > > drivers/mfd/kempld-core.c | 7 +++++--
> > > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > I was going to stop taking patches for this cycle, but as this looks
> > like a bugfix I'll apply it, thanks.
> >
>
> Hi Lee,
>
> Great.
>
> I should have added a note - the patch will also be needed in -stable;
> the driver is used in both 3.12 and 3.13.

Very well. I'll add the Cc to the commit log.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/