Re: Tasks stuck in futex code (in 3.14-rc6)
From: Linus Torvalds
Date: Thu Mar 20 2014 - 14:37:24 EST
On Thu, Mar 20, 2014 at 10:18 AM, Davidlohr Bueso <davidlohr@xxxxxx> wrote:
> Comparing with the patch I sent earlier this morning, looks equivalent,
> and fwiw, passes my initial qemu bootup, which is the first way of
> detecting anything stupid going on.
> So, Srikar, please try this patch out, as opposed to mine, you don't
> have to first revert the commit in question.
Ok, so it boots for me too, so hopefully it isn't totally broken.
However, since it's just closing a race, and since getting the counts
wrong should easily result in it *working* but always taking the slow
path (for example), I'd really like people to also verify that it
fixes the actual performance issue (ie assuming it fixes powerpc
behavior for Srikar, I'd like to get it double-checked that it also
avoids the spinlock in the common case). Because if the
increment/decrement pairings end up being wrong, we could have a
situation where the waiter count just ends up bogus, and it all works
from a correctness standpoint but not from the intended performance
No way I can test that sanely on my single-socket machine. Davidlohr?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/