Re: [PATCH 2/2] coding style: fix line over 80 characters

[Sergei Shtylyov]

On 03/21/2014 12:34 AM, Sergei Shtylyov wrote:

> > Signed-off-by: CÃdric Cabessa <ced@xxxxxxxxx>
> > ---
> >   drivers/staging/usbip/vhci_hcd.c | 33 ++++++++++++++++++++++-----------
> >   1 file changed, 22 insertions(+), 11 deletions(-)

> > diff --git a/drivers/staging/usbip/vhci_hcd.c
> > b/drivers/staging/usbip/vhci_hcd.c
> > index f690668..1e84577 100644
> > --- a/drivers/staging/usbip/vhci_hcd.c
> > +++ b/drivers/staging/usbip/vhci_hcd.c
[...]
> > @@ -539,7 +546,9 @@ static int vhci_urb_enqueue(struct usb_hcd *hcd, struct
> > urb *urb,
> >
> >           default:
> >               /* NOT REACHED */
> > -            dev_err(dev, "invalid request to devnum 0 bRequest %u, wValue
> > %u\n", ctrlreq->bRequest,
> > +            dev_err(dev,
> > +                "invalid request to devnum 0 bRequest %u, wValue %u\n",
> > +                ctrlreq->bRequest,
> >                   ctrlreq->wValue);
> >               ret =  -EINVAL;
> >               goto no_need_xmit;
> > @@ -1060,7 +1069,9 @@ static int vhci_hcd_suspend(struct platform_device
> > *pdev, pm_message_t state)
> >       spin_unlock(&the_controller->lock);
> >
> >       if (connected > 0) {
> > -        dev_info(&pdev->dev, "We have %d active connection%s. Do not
> > suspend.\n", connected, (connected == 1 ? "" : "s"));
> > +        dev_info(&pdev->dev,
> > +             "We have %d active connection%s. Do not suspend.\n",
> > +             connected, (connected == 1 ? "" : "s"));
> >           ret =  -EBUSY;
> >       } else {
> >           dev_info(&pdev->dev, "suspend vhci_hcd");

>     Hm, I don't see checkpatch.pl complaints about these either in the
> 'usb-next' branch of Greg's tree.

   Sorry, I forgot about Greg's separate staging.git repo. The patch looks 
correct in this context.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/