Re: [PATCH v2] staging: cxt1e1: replace OS_kmalloc/OS_kfree with kmalloc/kfree

From: Greg KH
Date: Fri Mar 21 2014 - 00:26:23 EST


On Fri, Mar 21, 2014 at 01:15:23PM +0900, Daeseok Youn wrote:
>
> Replace OS_kmalloc/OS_kfree with kmalloc/kfree.

You should replace it with kzalloc, not kmalloc, as OS_kmalloc() zeroed
out the allocated data:


> -static inline void *
> -OS_kmalloc (size_t size)
> -{
> - char *ptr = kmalloc (size, GFP_KERNEL | GFP_DMA);
> -
> - if (ptr)
> - memset (ptr, 0, size);
> - return ptr;
> -}

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/