Re: [PATCH/RFC 1/8] leds: Add sysfs and kernel internal API for flash LEDs

[Jacek Anaszewski]

On 03/20/2014 04:28 PM, Richard Purdie wrote:
> On Thu, 2014-03-20 at 15:51 +0100, Jacek Anaszewski wrote:
> > Some LED devices support two operation modes - torch and
> > flash. This patch provides support for flash LED devices
> > in the LED subsystem by introducing new sysfs attributes
> > and kernel internal interface. The attributes being
> > introduced are: flash_mode, flash_timeout, max_flash_timeout,
> > flash_fault and hw_triggered.
> > The modifications aim to be compatible with V4L2 framework
> > requirements related to the flash devices management. The
> > design assumes that V4L2 driver can take of the LED class
> > device control and communicate with it through the kernel
> > internal interface. The LED sysfs interface is made
> > unavailable then.
> >
> > Signed-off-by: Jacek Anaszewski <j.anaszewski@xxxxxxxxxxx>
> > Acked-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> > Cc: Bryan Wu <cooloney@xxxxxxxxx>
> > Cc: Richard Purdie <rpurdie@xxxxxxxxx>
> > ---
> >   drivers/leds/led-class.c    |  216 +++++++++++++++++++++++++++++++++++++++++--
> >   drivers/leds/led-core.c     |  124 +++++++++++++++++++++++--
> >   drivers/leds/led-triggers.c |   17 +++-
> >   drivers/leds/leds.h         |    9 ++
> >   include/linux/leds.h        |  136 +++++++++++++++++++++++++++
> >   5 files changed, 486 insertions(+), 16 deletions(-)
>
> It seems rather sad to have to insert that amount of code into the core
> LED files for something which only a small number of LEDs actually use.
> This will increase the footprint of the core LED code significantly.
>
> Is it not possible to add this as a module/extension to the LED core
> rather than completely entangling them?

OK, I'll try to decouple it.

Thanks,
Jacek Anaszewski

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/