Re: [PATCH] drivers: staging: cxt1e1: hwprobe Fix different address spaces

[Denis Kirjanov]

On 3/21/14, Matei Oprea <eu@xxxxxxxxxxxxx> wrote:
> Fix different address spaces when unmapping IO. hi->addr_mapped[0]
> and hi->addr_mapped[1] should be tagged __iomem.
>
> Signed-off-by: Matei Oprea <eu@xxxxxxxxxxxxx>
> Cc: ROSEdu Kernel Community <firefly@xxxxxxxxxxxxxxxx>
> ---
>  drivers/staging/cxt1e1/hwprobe.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/cxt1e1/hwprobe.c
> b/drivers/staging/cxt1e1/hwprobe.c
> index 9b4198b..f55c27e 100644
> --- a/drivers/staging/cxt1e1/hwprobe.c
> +++ b/drivers/staging/cxt1e1/hwprobe.c
> @@ -174,12 +174,12 @@ cleanup_ioremap(void)
>  		if (hi->pci_slot == 0xff)
>  			break;
>  		if (hi->addr_mapped[0]) {
> -			iounmap((void *)(hi->addr_mapped[0]));
> +			iounmap((void __iomem *)(hi->addr_mapped[0]));
>  			release_mem_region((long) hi->addr[0], hi->len[0]);
>  			hi->addr_mapped[0] = 0;
>  		}
>  		if (hi->addr_mapped[1]) {
> -			iounmap((void *)(hi->addr_mapped[1]));
> +			iounmap((void __iomem *)(hi->addr_mapped[1]));
>  			release_mem_region((long) hi->addr[1], hi->len[1]);
>  			hi->addr_mapped[1] = 0;
>  		}

__iomem annotations should be added to the private structure pointers.
Look at the iounmap usage in the drivers.

> --
> 1.7.9.5
>
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>


-- 
Regards,
Denis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/