RE: [PATCH net-next,v4] hyperv: Add support for virtual Receive Side Scaling (vRSS)

[Haiyang Zhang]

> -----Original Message-----
> From: David Miller [mailto:davem@xxxxxxxxxxxxx]
> Sent: Friday, March 21, 2014 2:55 PM
> To: Haiyang Zhang
> Cc: netdev@xxxxxxxxxxxxxxx; KY Srinivasan; olaf@xxxxxxxxx;
> jasowang@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; driverdev-
> devel@xxxxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH net-next,v4] hyperv: Add support for virtual Receive
> Side Scaling (vRSS)
> 
> From: David Miller <davem@xxxxxxxxxxxxx>
> Date: Fri, 21 Mar 2014 14:49:57 -0400 (EDT)
> 
> > From: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> > Date: Thu, 20 Mar 2014 15:28:41 -0700
> >
> >> This feature allows multiple channels to be used by each virtual NIC.
> >> It is available on Hyper-V host 2012 R2.
> >>
> >> Signed-off-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> >> Reviewed-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> >
> > Applied, thanks.
> 
> Actually I had to revert, this doesn't even compile.
> 
> drivers/net/hyperv/netvsc.c: In function ʽnetvsc_channel_cbʼ:
> drivers/net/hyperv/netvsc.c:891:2: error: implicit declaration of
> function ʽget_per_channel_stateʼ [-Werror=implicit-function-declaration]
> drivers/net/hyperv/netvsc.c:891:9: warning: assignment makes pointer
> from integer without a cast [enabled by default]
> drivers/net/hyperv/netvsc.c: In function ʽnetvsc_device_addʼ:
> drivers/net/hyperv/netvsc.c:998:2: error: implicit declaration of
> function ʽset_per_channel_stateʼ [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[3]: *** [drivers/net/hyperv/netvsc.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
> drivers/net/hyperv/rndis_filter.c: In function ʽnetvsc_sc_openʼ:
> drivers/net/hyperv/rndis_filter.c:988:2: error: implicit declaration of
> function ʽset_per_channel_stateʼ [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[3]: *** [drivers/net/hyperv/rndis_filter.o] Error 1
> make[2]: *** [drivers/net/hyperv] Error 2
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [drivers/net] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [drivers] Error 2

The per channel state variable and functions are defined by this patch,
which has been applied on 2/07:
Drivers: hv: vmbus: Support per-channel driver state
http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=8a7206a89f85c8439561b0eff85bb9440a2e97a9

Could it be merged into net-next tree?

Thanks,
- Haiyang

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/