Re: [PATCH] usb: musb: Fix obex in g_nokia.ko causing kernel panic

[Rabin Vincent]

2014-02-06 20:25 GMT+01:00 Ivaylo Dimitrov <ivo.g.dimitrov.75@xxxxxxxxx>:
> From: Felipe Balbi <balbi@xxxxxx>

This patch, which is present in 3.14-rc4 as 30a70b026 ("usb: musb: fix
obex in g_nokia.ko causing kernel panic"), breaks USB gadget support
on my Pandaboard.  Bisecting points to this commit, reverting it makes
USB gadget support work again.  The problem is that this patch deletes
the call which turns on the PHY.

Config is attached.

> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
> index 2a408cd..8aa59a2 100644
> --- a/drivers/usb/musb/omap2430.c
> +++ b/drivers/usb/musb/omap2430.c
> @@ -659,7 +659,6 @@ static int omap2430_runtime_suspend(struct device *dev)
>                                 OTG_INTERFSEL);
>
>                 omap2430_low_level_exit(musb);
> -               phy_power_off(musb->phy);
>         }
>
>         return 0;
> @@ -674,7 +673,6 @@ static int omap2430_runtime_resume(struct device *dev)
>                 omap2430_low_level_init(musb);
>                 musb_writel(musb->mregs, OTG_INTERFSEL,
>                                 musb->context.otg_interfsel);
> -               phy_power_on(musb->phy);
>         }
>
>         return 0;

Attachment: panda-usb-config.gz
Description: GNU Zip compressed data