Re: [PATCH] lkdtm: include cacheflush.h

[Kees Cook]

On Fri, Mar 21, 2014 at 1:36 PM, Paul Gortmaker
<paul.gortmaker@xxxxxxxxxxxxx> wrote:
> On 14-03-21 03:33 PM, Kees Cook wrote:
>> On Fri, Mar 21, 2014 at 12:31 PM, Paul Gortmaker
>> <paul.gortmaker@xxxxxxxxxxxxx> wrote:
>>> On Fri, Feb 14, 2014 at 6:58 PM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>>>> Some architectures need cacheflush.h explicitly included (mips) for
>>>> use of flush_icache_range():
>>>>
>>>>     config: make ARCH=mips allmodconfig
>>>>     All error/warnings:
>>>>     >> ERROR: "flush_icache_range" undefined!
>>>
>>> The linux-next builds still fail with a similar error:
>>>
>>> http://kisskb.ellerman.id.au/kisskb/buildresult/10808358/
>>>
>>> I'm not sure if it ever was a compile error, or if it was always
>>> a missing export symbol type error as it is apparently now.
>>
>> It seems no one picked up this fix? Greg, you normally take my lkdtm work...
>
> No, the "fix" is there, in linux-next, but it doesn't work.  :)

Oh! So it is. Does anyone have a MIPS builder available to figure out
the right fix? I'll try to get a cross builder set up for this.

A more careful look at this would seem to indicate the problem is the
lack of an EXPORT, rather than the missing declaration. I'll dig in to
this.

Sorry for the noise!

-Kees

>
> Paul.
> --
>
>>
>> -Kees
>>
>>>
>>> Paul.
>>> --
>>>
>>>>
>>>> Reported-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
>>>> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>>>> ---
>>>>  drivers/misc/lkdtm.c |    1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/misc/lkdtm.c b/drivers/misc/lkdtm.c
>>>> index 47ed2d321351..2ebd52e05773 100644
>>>> --- a/drivers/misc/lkdtm.c
>>>> +++ b/drivers/misc/lkdtm.c
>>>> @@ -46,6 +46,7 @@
>>>>  #include <linux/debugfs.h>
>>>>  #include <linux/vmalloc.h>
>>>>  #include <linux/mman.h>
>>>> +#include <asm/cacheflush.h>
>>>>
>>>>  #ifdef CONFIG_IDE
>>>>  #include <linux/ide.h>
>>>> --
>>>> 1.7.9.5
>>>>
>>>>
>>>> --
>>>> Kees Cook
>>>> Chrome OS Security
>>>> --
>>>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>>>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>>> Please read the FAQ at  http://www.tux.org/lkml/
>>
>>
>>



-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/