Re: [PATCH 3.13 072/149] ACPI / resources: ignore invalid ACPI device resources

[Greg Kroah-Hartman]

On Sat, Mar 22, 2014 at 02:30:43AM +0000, Stefan Lippers-Hollmann wrote:
> Hi
> 
> On Friday 21 March 2014, Greg Kroah-Hartman wrote:
> > 3.13-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Zhang Rui <rui.zhang@xxxxxxxxx>
> > 
> > commit b355cee88e3b1a193f0e9a81db810f6f83ad728b upstream.
> > 
> > ACPI table may export resource entry with 0 length.
> > But the current code interprets this kind of resource in a wrong way.
> > It will create a resource structure with
> > res->end = acpi_resource->start + acpi_resource->len - 1;
> > 
> > This patch fixes a problem on my machine that a platform device fails
> > to be created because one of its ACPI IO resource entry (start = 0,
> > end = 0, length = 0) is translated into a generic resource with
> > start = 0, end = 0xffffffff.
> > 
> > Signed-off-by: Zhang Rui <rui.zhang@xxxxxxxxx>
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> [...]
> 
> This patch should probably be dropped from -stable (3.13 and 3.10) for 
> the time being, it causes this warning:
> 
> pnp 00:01: unknown resource type 4 in _CRS
> pnp 00:01: can't evaluate _CRS: 1
> 
> on all systems I've tested it on so far (~12 systems of vastly varying 
> components and age, covering amd64 and i386).
> 
> This also seems to affect others as well:
> 	http://www.spinics.net/lists/linux-acpi/msg49431.html
> 	http://www.spinics.net/lists/linux-acpi/msg49438.html

Is this also a problem in Linus's tree?  If so, shouldn't a fix go there
first?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/