On Sat, 2014-03-22 at 08:48 -0700, behanw@xxxxxxxxxxxxxxxxxx wrote:It is also supported by clang.
From: Behan Webster <behanw@xxxxxxxxxxxxxxxxxx>No, that's got to be unreachable() so that it works in all compilers,
Fix uninitialized return code in default case in cmpxchg-local.h
This patch fixes the code to prevent an uninitialized return value that is detected
when compiling with clang. The bug produces numerous warnings when compiling the
Linux kernel with clang.
Signed-off-by: Behan Webster <behanw@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Mark Charlebois <charlebm@xxxxxxxxx>
include/asm-generic/cmpxchg-local.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/asm-generic/cmpxchg-local.h b/include/asm-generic/cmpxchg-local.h
index d8d4c89..9112111 100644
@@ -41,6 +41,7 @@ static inline unsigned long __cmpxchg_local_generic(volatile void *ptr,
(__builtin_unreachable is a gcc-4 ism).
Got to say this still looks wrong. If wrong_size_cmpxchg() cannotOkay. I can try that instead.
return, the function should be annotated as such with __noreturn (like
panic()) so the unreachable() should be superfluous.