RE: [PATCH 1/3] ARM: dts: vf610: Add Freescale FTM PWM node.

[Li.Xiubo@xxxxxxxxxxxxx]

> Subject: Re: [PATCH 1/3] ARM: dts: vf610: Add Freescale FTM PWM node.
> 
> On Thu, Mar 20, 2014 at 01:12:03PM +0800, Xiubo Li wrote:
> > This adds devicetree node for VF610, and there are 8 channels
> > supported.
> >
> > Signed-off-by: Xiubo Li <Li.Xiubo@xxxxxxxxxxxxx>
> > Reviewed-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> > Reviewed-by: Yuan Yao <yao.yuan@xxxxxxxxxxxxx>
> 
> Please copy list linux-arm-kernel instead of linux-kernel on arch/arm/
> changes, and also be noted that my email and git addresses just got
> updated [1].
> 

Okey.

> > ---
> >  arch/arm/boot/dts/vf610.dtsi | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
> > index acf544e..ccc6d35 100644
> > --- a/arch/arm/boot/dts/vf610.dtsi
> > +++ b/arch/arm/boot/dts/vf610.dtsi
> > @@ -192,6 +192,19 @@
> >  				status = "disabled";
> >  			};
> >
> > +			pwm0: pwm@40038000 {
> 
> The node should be sorted in unit-address.  So shouldn't it be put right
> after pit node?
> 

Yes, I will fix it.

Thanks,

BRs,
Xiubo


> Shawn
> 
> [1]
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=f1c
> 12837220c54c8d7138a4ee4a08c1ec67b68a2
> 
> > +				compatible = "fsl,vf610-ftm-pwm";
> > +				#pwm-cells = <3>;
> > +				reg = <0x40038000 0x1000>;
> > +				clock-names = "ftm_sys", "ftm_ext",
> > +					      "ftm_fix", "ftm_cnt_clk_en";
> > +				clocks = <&clks VF610_CLK_FTM0>,
> > +					<&clks VF610_CLK_FTM0_EXT_SEL>,
> > +					<&clks VF610_CLK_FTM0_FIX_SEL>,
> > +					<&clks VF610_CLK_FTM0_EXT_FIX_EN>;
> > +				status = "disabled";
> > +			};
> > +
> >  			wdog@4003e000 {
> >  				compatible = "fsl,vf610-wdt", "fsl,imx21-wdt";
> >  				reg = <0x4003e000 0x1000>;
> > --
> > 1.8.4
> >
> >

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/