Re: [PATCH -tip v8 12/26] ftrace/*probes: Allow probing on some functions

[Masami Hiramatsu]

(2014/03/25 4:38), Steven Rostedt wrote:
> On Wed, 05 Mar 2014 21:00:07 +0900
> Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx> wrote:
> 
>> --- a/kernel/trace/trace_kprobe.c
>> +++ b/kernel/trace/trace_kprobe.c
>> @@ -1209,7 +1209,7 @@ kretprobe_perf_func(struct trace_kprobe *tk, struct kretprobe_instance *ri,
>>   * kprobe_trace_self_tests_init() does enable_trace_probe/disable_trace_probe
>>   * lockless, but we can't race with this __init function.
>>   */
>> -static __kprobes
>> +static
>>  int kprobe_register(struct ftrace_event_call *event,
> 
> Please keep the static on the same line as int. Either the above is one
> line or:
> 
> static int
> kprobe_register(...)
> 
> Like the rest of the patch does.

I see, I'll update it. :)

Thank you,

> 
> -- Steve
> 
> 


-- 
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@xxxxxxxxxxx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/