Re: [PATCH -tip v8 17/26] notifier: Use NOKPROBE_SYMBOL macro in notifier

[Masami Hiramatsu]

(2014/03/25 5:12), Steven Rostedt wrote:
> On Wed, 05 Mar 2014 21:00:42 +0900
> Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx> wrote:
> 
>> Use NOKPROBE_SYMBOL macro to protect functions from
>> kprobes instead of __kprobes annotation in notifier.
>>
>> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>
> 
>>  /*
>>   *	Blocking notifier chain routines.  All access to the chain is
>> @@ -527,7 +530,7 @@ EXPORT_SYMBOL_GPL(srcu_init_notifier_head);
>>  
>>  static ATOMIC_NOTIFIER_HEAD(die_chain);
>>  
>> -int notrace __kprobes notify_die(enum die_val val, const char *str,
>> +int notrace notify_die(enum die_val val, const char *str,
> 
> Hmm, I wonder why notify_die() is marked notrace? But that's unrelated
> to this patch.
> 
> Reviewed-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

Thanks! I guess since notify_die() is called from any kind of fault,
which may be happen inside ftrace too.

Thank you,

-- 
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@xxxxxxxxxxx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/