Re: [PATCH] staging: silicom: hide conditionally used function in condition

[Greg KH]

On Wed, Mar 26, 2014 at 02:58:50PM +0900, SeongJae Park wrote:
> bp_proc_create() be called only when BP_PROC_SUPPORT defined but its
> definition live outside of #ifdef BP_PROC_SUPPORT and cause following
> trivial build warning:
> drivers/staging/silicom/bpctl_mod.c:6786:12: warning:
> âbp_proc_createâ defined but not used [-Wunused-function]
>  static int bp_proc_create(void)
>             ^
> 
> Fix the warning by hide the definition inside #ifdef BP_PROC_SUPPORT.

But no one can define that value, so why add more usages, it should just
be ripped out.  Just remove everything "hidden" by this option as no
one is obviously using it, and no driver should be messing around in
/proc anyway.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/