Re: [PATCH] usb: gadget: zero: Fix SuperSpeed enumeration for alternate setting 1

From: Sergei Shtylyov
Date: Wed Mar 26 2014 - 09:07:35 EST


Hello.

On 26-03-2014 13:28, Roger Quadros wrote:

It was impossible to enumerate on a SuperSpeed (XHCI) host
with alternate setting = 1 due to the wrongly set 'bMaxBurst'
field in the SuperSpeed Endpoint Companion descriptor.

Testcase:
<host> modprobe -r usbtest; modprobe usbtest alt=1
<device> modprobe g_zero
plug device to SuperSpeed port on the host.

Without this patch the host always complains like so
"usb 12-2: Not enough bandwidth for new device state.
usb 12-2: Not enough bandwidth for altsetting 1"

Bug was introduced by commit cf9a08ae in v3.9

Please also specify that commit's summary in parens. Also, there's now an adopted standard way of saying this:

Fixes: <12-digit SHA ID> ("<summary line>")

Cc: 3.9+ <stable@xxxxxxxxxxxxxxx> # 3.9+
Cc: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
Reviewed-by: Felipe Balbi <balbi@xxxxxx>
Signed-off-by: Roger Quadros <rogerq@xxxxxx>

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/