Re: [PATCH net-next v3 1/3] xen-netback: Stop using xenvif_tx_pending_slots_available
From: David Miller
Date: Wed Mar 26 2014 - 16:34:10 EST
From: Zoltan Kiss <zoltan.kiss@xxxxxxxxxx>
Date: Mon, 24 Mar 2014 23:59:49 +0000
> Since the early days TX stops if there isn't enough free pending slots to
> consume a maximum sized (slot-wise) packet. Probably the reason for that is to
> avoid the case when we don't have enough free pending slot in the ring to finish
> the packet. But if we make sure that the pending ring has the same size as the
> shared ring, that shouldn't really happen. The frontend can only post packets
> which fit the to the free space of the shared ring. If it doesn't, the frontend
> has to stop, as it can only increase the req_prod when the whole packet fits
> onto the ring.
> This patch avoid using this checking, makes sure the 2 ring has the same size,
> and remove a checking from the callback. As now we don't stop the NAPI instance
> on this condition, we don't have to wake it up if we free pending slots up.
>
> Signed-off-by: Zoltan Kiss <zoltan.kiss@xxxxxxxxxx>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/