Re: [PATCH v3] ata: fix Marvell SATA driver dependencies

From: Sebastian Hesselbarth
Date: Thu Mar 27 2014 - 08:46:40 EST


On 03/27/2014 01:38 PM, Andrew Lunn wrote:
On Thu, Mar 27, 2014 at 01:23:39PM +0100, Bartlomiej Zolnierkiewicz wrote:
Make sata_mv host driver depend on PCI || ARCH_DOVE || ARCH_KIRKWOOD ||
ARCH_MV78XX0 || ARCH_MVEBU || ARCH_ORION5X config options as Marvell
SATA support covers both Marvell PCI devices and Marvell Dove, Kirkwood,
MV78xx0, Armada 370/XP and Orion5x SoCs (for non-PCI devices the driver
to work requires suitable device tree node to be defined).

Good old fashioned platform driver will also work. In fact, 95% of Orion5x
and mv78xx0 devices don't have DT yet.

You might also be able to simplify it to

PCI || PLAT_ORION || COMPILE_TEST

But i suggest you build test to make sure.

Please, don't do it. We are in the progress of getting rid of
PLAT_ORION. v3 is just fine, or keep at least ARCH_MVEBU:

PCI || PLAT_ORION || ARCH_MVEBU || COMPILE_TEST

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/