Re: [PATCH v1] net-sysfs: expose number of link up/down transitions

[Florian Fainelli]

2014-03-27 22:17 GMT-07:00 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>:
> Hi David,
>
> On Thu, 27 Mar 2014 21:35:00 -0700 David Decotigny <decot@xxxxxxxxxxxx> wrote:
>>
>> Tested:
>>   grep . /sys/class/net/*/count_link_*
>>   + ip link set dev X down/up
>>
>> Signed-off-by: David Decotigny <decot@xxxxxxxxxxxx>
>
> It is not a very enlightening commit message.  You should tell us why we
> should add this to the kernel.

This might be useful to detect unstable links for instance, by
measuring how many link transitions you get, which could indicate that
either your NIC or your link partner is at fault.

If possible this should come with a Documentation/ABI/testing/ entry,
quite a lot of network sysfs attributes are lacking one at the moment,
but there is no reason why this should continue.
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/