Re: [PATCHv2 1/1] mtd: gpmi: make blockmark swapping optional

From: Huang Shijie
Date: Fri Mar 28 2014 - 06:08:13 EST


ä 2014å03æ28æ 17:31, Lothar WaÃmann åé:
Hi,

Huang Shijie wrote:
ä 2014å03æ28æ 17:00, Sascha Hauer åé:
- disables swapping of BB marks in the FCB the ROM won't swap bytes.
We can not disable the swapping in the FCB in the imx28.
The DISBBM bit in the FCB does _NOT_ exit in the imx28's FCB.

The Linux kernel does not have any business with the FCB, so it is
completely irrelevant for Linux whether byte swapping can be disabled
in the FCB or not.

But the gpmi is relevant to the ROM.
the gpmi driver should keep consistency with the ROM.

I do not object you add the swapping optional the gpmi driver(since it's ok for imx50/imx6q/imx6sx),
i just object that you enable this feature for imx28.



thanks
Huang Shijie

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/