Re: [PATCH] phy/at8031: enable at8031 to work on interrupt mode

[Sergei Shtylyov]

Hello.

On 03/28/2014 10:36 AM, qiang.zhao@xxxxxxxxxxxxx wrote:

> > > The at8031 can work on polling mode and interrupt mode.
> > > Add ack_interrupt and config intr funcs to enable interrupt mode for
> > > it.

> > > Signed-off-by: Zhao Qiang <B45475@xxxxxxxxxxxxx>
> > > ---
> > >    drivers/net/phy/at803x.c | 30 ++++++++++++++++++++++++++++++
> > >    1 file changed, 30 insertions(+)

> > > diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index
> > > bc71947..d034ef5 100644
> > > --- a/drivers/net/phy/at803x.c
> > > +++ b/drivers/net/phy/at803x.c
> > [...]
> > > @@ -191,6 +194,31 @@ static int at803x_config_init(struct phy_device
> > *phydev)
> > >    	return 0;
> > >    }
> > >
> > > +static int at803x_ack_interrupt(struct phy_device *phydev) {
> > > +	int err;
> > > +
> > > +	err = phy_read(phydev, AT803X_INSR);

> >      Could make this an initializer...

> Thank you very much. However I have no idea about "make this an initializer".

	int err = phy_read(phydev, AT803X_INSR);

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/