Re: [PATCH v2 13/29] ktap: add ring buffer handling code(kernel/trace/ktap/kp_transport.[c|h])

From: Jovi Zhangwei
Date: Sun Mar 30 2014 - 03:41:51 EST


On Sun, Mar 30, 2014 at 11:58 AM, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
>>
>> A lot of code in this file is duplicated with kernel trace_output.c.
>
> Please modify trace_output instead to avoid this.
>
Yeah, ktap transport functionality is based on ftrace ring buffer,
and reading buffer is through trace pipe.

I will try to figure out some way to reuse ftrace trace pipe reading
code as much as possible.

Thanks.

Jovi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/