Re: [PATCH 3/3] staging/ozwpan: coding style ether_addr_copy

From: Dan Carpenter
Date: Sun Mar 30 2014 - 06:44:34 EST


On Sat, Mar 29, 2014 at 06:23:26PM -0700, Joe Perches wrote:
> On Sun, 2014-03-30 at 02:29 +0300, Dan Carpenter wrote:
> > These days in the kernel we treat checkpatch.pl and GCC
> > warnings the same so it sucks when they are something conditional.
>
> Treating checkpatch messages like gcc compilation warnings
> and failures has got to change.
>
> There is _no way_ checkpatch can have no false positives.
>

We could argue back and forth, but for now lets just revert the
ether_addr_copy() check because people ignore the alignement requirement
and it just encourages people to introduce bugs.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/