Re: [PATCH net-next v2] net-sysfs: expose number of carrier on/off changes

[David Decotigny]

Hi all,

As Eric mentioned, this is a per-link counter. I am not sure an
aggregate stat would be as useful.

As suggested by Florian, I'm planning to add a doc. As far as I can
tell, I think it goes beyond just documenting this new counter: I
believe sysfs-class-net needs to be added as a whole.

Stephen: I have a patch for iproute2, I was planning to send it after
we're done with this one, unless you want it now. Also, should I
document this IFLA thing, where would be best?

On Sat, Mar 29, 2014 at 6:50 PM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
> On Sat, 2014-03-29 at 18:36 -0700, Stephen Hemminger wrote:
>> On Sat, 29 Mar 2014 09:48:35 -0700
>> David Decotigny <decot@xxxxxxxxxxxx> wrote:
>>
>> > This allows to monitor carrier on/off transitions and detect link
>> > flapping issues:
>> >  - new /sys/class/net/X/carrier_changes
>> >  - new rtnetlink IFLA_CARRIER_CHANGES (getlink)
>> >
>> > Tested:
>> >   - grep . /sys/class/net/*/carrier_changes
>> >     + ip link set dev X down/up
>> >     + plug/unplug cable
>> >   - updated iproute2: prints IFLA_CARRIER_CHANGES
>> >   - iproute2 20121211-2 (debian): unchanged behavior
>> >
>> > Signed-off-by: David Decotigny <decot@xxxxxxxxxxxx>
>>
>> Is there a related SNMP MIB variable? should there be?
>
> I don't think we have any SNMP MIB variable for devices ?
>
> It seems "ip link" is the facto standard.
>
> (BTW we put BusyPollRxPackets in TcpExt group, this was an error IMHO)
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/