RE: [PATCH 21/55] scsi: Mark function as static in isci/port.c

From: Dorau, Lukasz
Date: Mon Mar 31 2014 - 04:56:44 EST


On Saturday, March 29, 2014 7:07 PM Rashika Kheria <rashika.kheria@xxxxxxxxx> wrote:
> Mark function as static in isci/port.c because they are not used outside
> this file.
>
> This eliminates the following warning in isci/port.c:
> drivers/scsi/isci/port.c:65:13: warning: no previous prototype for
> âport_state_nameâ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx>
> Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>

Acked-by: Lukasz Dorau <lukasz.dorau@xxxxxxxxx>

> ---
> drivers/scsi/isci/port.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/isci/port.c b/drivers/scsi/isci/port.c
> index 13098b0..225d39f 100644
> --- a/drivers/scsi/isci/port.c
> +++ b/drivers/scsi/isci/port.c
> @@ -62,7 +62,7 @@
>
> #undef C
> #define C(a) (#a)
> -const char *port_state_name(enum sci_port_states state)
> +static const char *port_state_name(enum sci_port_states state)
> {
> static const char * const strings[] = PORT_STATES;
>
> --
> 1.7.9.5