Re: [PATCH] Add initcall_blacklist kernel parameter [v2]

[Andi Kleen]

>  		do_initcall_level(level);
> +
> +	list_for_each_safe(tmp, next, &blacklisted_initcalls) {
> +		entry = list_entry(tmp, struct blacklist_entry, next);
> +		free_bootmem(entry->buf, strlen(entry->buf));
> +		free_bootmem(entry, sizeof(*entry));

Does that really work? At this point the bootmem allocator should
be already finished, so no memory will be freed.

For this case it's probably ok to leak it.

Alternatively you could use static arrays and storing pointer/len.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/