Re: [PATCH v2] fs: FAT: Add support for DOS 1.x formatted volumes

[Stephen Rothwell]

On Mon, 31 Mar 2014 15:32:32 -0700 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Mon, 31 Mar 2014 15:21:17 -0700 Conrad Meyer <cse.cem@xxxxxxxxx> wrote:
> 
> > >> +     if (get_unaligned_le16(&b->sector_size) != 0 || b->sec_per_clus != 0 ||
> > >> +             b->reserved != 0 || b->fats != 0 ||
> > >> +             get_unaligned_le16(&b->dir_entries) != 0 ||
> > >> +             get_unaligned_le16(&b->sectors) != 0 || b->media != 0 ||
> > >> +             b->fat_length != 0 || b->secs_track != 0 || b->heads != 0 ||
> > >> +             b->secs_track != 0 || b->heads != 0)
> > >
> > > Impressive!
> > 
> > I aim to please.
> 
> No great improvements immediately occur to me ;)
> 
> One could do
> 
> 	/* nice comment */
> 	if (get_unaligned_le16(&b->sector_size) != 0)
> 		return;
> 	/* another nice comment */
> 	if (b->sec_per_clus != 0)
> 		return;
> 	...
> 
> but one would quickly run out of nice comments.
> 
> You could do s/ != 0//g.

You could also put the boolean expression in a (hopefully expressively
named) helper function and do the tests separately there.

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx

Attachment: pgpJf8wFI5vgt.pgp
Description: PGP signature