Re: [RFC 2/4] timer: don't migrate pinned timers

From: Viresh Kumar
Date: Tue Apr 01 2014 - 00:32:54 EST


On 31 March 2014 21:26, Kevin Hilman <khilman@xxxxxxxxxx> wrote:
> Viresh Kumar <viresh.kumar@xxxxxxxxxx> writes:
>> + if (is_pinned) {
>> + pr_warn("%s: can't migrate pinned timer: %p, removing it\n",
>> + __func__, timer);
>
> printk message will be confusing: removing it from what?

Hmm.. So, I am looking to do two modifications here. Just need inputs
if that would be the right thing to do:

- do a WARN() here as these timers should have been already removed
- change print to: "can't migrate pinned timer %p, deactivating timer"

Looks fine?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/