Re: [patch 00/12] can: c_can: Fix a series of serious bugs and improve the performance
From: Marc Kleine-Budde
Date: Tue Apr 01 2014 - 04:09:43 EST
On 04/01/2014 12:35 AM, Thomas Gleixner wrote:
> Dear Maintainers,
>
> On Tue, 18 Mar 2014, Thomas Gleixner wrote:
>> The driver is full of serious bugs:
>>
>> - Two HW init routines are not spec compliant.
>>
>> - Completely defective message buffer handling in several ways
>> That leads to interrupt storms and complete lockups.
>>
>> - Complete lack of SMP awareness
>>
>> What's amazing is that people "optimize" and "fix" the driver over and
>> over, but nobody bothered to understand the manual and repair the code
>> for real.
>>
>> The series fixes _ALL_ bugs which I found so far, but I'm sure there
>> are more issues burried in that unreadable mess. I'm just not able to
>> trigger them.
>
> What's the state of this series?
I'll apply your patches today.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Attachment:
signature.asc
Description: OpenPGP digital signature