Re: [PATCH] video: da8xx-fb: Add support for Densitron 84-0023-001T

[Tomi Valkeinen]

Hi,

On 05/03/14 20:05, jon@xxxxxxxxxx wrote:
> From: Jon Ringle <jringle@xxxxxxxxxxxxx>
> 
> Signed-off-by: Jon Ringle <jringle@xxxxxxxxxxxxx>
> ---
>  drivers/video/da8xx-fb.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
> index e7f5937..83c43b2 100644
> --- a/drivers/video/da8xx-fb.c
> +++ b/drivers/video/da8xx-fb.c
> @@ -243,6 +243,20 @@ static struct fb_videomode known_lcd_panels[] = {
>  		.sync           = FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
>  		.flag           = 0,
>  	},
> +	[3] = {
> +		/* Densitron 84-0023-001T */
> +		.name           = "Densitron_LCD",

I think the name should be a bit better. Why it is not something like
"Densitron_84-0023-001T", which is the style the other panels use?

 Tomi

Attachment: signature.asc
Description: OpenPGP digital signature