Re: [PATCH 2/2 v3] initramfs: print error and shell out for unsupported content

From: Michal Marek
Date: Tue Apr 01 2014 - 08:23:51 EST


On 2014-04-01 13:23, Alexander Holler wrote:
> But as I already said, trying to use arbitrary filenames in a Makefile
> doesn't really work. There are still other problems, e.g. filenames with
> a / (directory separator), *, or some of the special make variables like $<.
>
> So the really working solution would be to get rid of that generated
> (and hidden) include. Modifying gen_init_cpio.c to browse and collect
> all filenames and types itself doesn't look like much work (an evening
> should be enough).
>
> The drawback is that such a solution would build the initramfs every
> time make is called (while CONFIG_INITRAMFS_SOURCE points to a
> directory), but I think that time is negligible.

Well, the cpio is embedded in the kernel image, so a rebuild of the cpio
means a relink of the kernel. One option would be to implement the
timestamp checking in gen_init_cpio.c, but I'm not sure if that's worth it.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/