Re: [PATCH 2/4] asmlinkage, x86: Add explicit __visible to arch/x86/*

[Linus Torvalds]

This still has these kinds of pointless changes. Why?

In the declaration of the function, the __visible is just noise. It's
not interesting to the caller, and doesn't add anything. In fact, I'd
argue that these kinds of declarations are not just noise, they are
*stupid* noise, because if the function is ever used by C code than
that "__visible" is pointless.

So get rid of the __visible. It's just more of the same confusion
where you think __visible and asmlinkage go together. They damn well
don't.

                  Linus

On Tue, Apr 1, 2014 at 10:32 AM, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
>  #include <asm/sections.h>
>
>  /* Interrupt handlers registered during init_IRQ */
> -extern asmlinkage void apic_timer_interrupt(void);
> -extern asmlinkage void x86_platform_ipi(void);
> -extern asmlinkage void kvm_posted_intr_ipi(void);
> -extern asmlinkage void error_interrupt(void);
> -extern asmlinkage void irq_work_interrupt(void);
...
> +extern asmlinkage __visible void apic_timer_interrupt(void);
> +extern asmlinkage __visible void x86_platform_ipi(void);
> +extern asmlinkage __visible void kvm_posted_intr_ipi(void);
> +extern asmlinkage __visible void error_interrupt(void);
> +extern asmlinkage __visible void irq_work_interrupt(void);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/