Re: [PATCH v5 3/3] memstick: Add realtek USB memstick host driver

[Andrew Morton]

On Tue, 1 Apr 2014 11:20:32 +0800 Roger <rogerable@xxxxxxxxxxx> wrote:

> On 03/25/2014 06:44 PM, rogerable@xxxxxxxxxxx wrote:
> > From: Roger Tseng <rogerable@xxxxxxxxxxx>
> >
> > Realtek USB memstick host driver provides memstick host support based on the
> > Realtek USB card reader MFD driver.
> >
> > Signed-off-by: Roger Tseng <rogerable@xxxxxxxxxxx>
> > ---
> >   drivers/memstick/host/Kconfig       |  10 +
> >   drivers/memstick/host/Makefile      |   1 +
> >   drivers/memstick/host/rtsx_usb_ms.c | 839 ++++++++++++++++++++++++++++++++++++
> >   3 files changed, 850 insertions(+)
> >   create mode 100644 drivers/memstick/host/rtsx_usb_ms.c
> Hi Andrew,
> 
> Since I'll have to send next revision(v6, to modify patch 1/3) and 
> you've commented v4, would you also comment or Ack the 3/3 of this one? 
> This should save one revision for me to make any necessary change.

It looks OK to my inexpert eye.  It would be better if Maxim and/or Alex
could review the code.  If that doesn't happen then I guess the best we
can do is to go ahead and merge it.  Have you worked out via which tree
the patches will be merged?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/