Re: [PATCH 1/2] ttyprintk: Fix wrong tty_unregister_driver() call in the error path

From: Jean Delvare
Date: Wed Apr 02 2014 - 08:24:47 EST


Le Wednesday 02 April 2014 Ã 12:29 +0200, Takashi Iwai a Ãcrit :
> ttyprintk driver calls tty_unregister_driver() wrongly in the error
> path of tty_register_driver(). Also, setting ttyprintk_driver to NULL
> is utterly superfluous, so let's get rid of it, too.
>
> Reported-by: Jean Delvare <jdelvare@xxxxxxx>
> Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
> ---
> drivers/char/ttyprintk.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/char/ttyprintk.c b/drivers/char/ttyprintk.c
> index daea84c41743..2a39c5790364 100644
> --- a/drivers/char/ttyprintk.c
> +++ b/drivers/char/ttyprintk.c
> @@ -210,10 +210,8 @@ static int __init ttyprintk_init(void)
> return 0;
>
> error:
> - tty_unregister_driver(ttyprintk_driver);
> put_tty_driver(ttyprintk_driver);
> tty_port_destroy(&tpk_port.port);
> - ttyprintk_driver = NULL;
> return ret;
> }
> device_initcall(ttyprintk_init);

Reviewed-by: Jean Delvare <jdelvare@xxxxxxx>

--
Jean Delvare
SUSE L3 Support

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/