Re: [GIT PULL] x86 LTO changes for v3.15

[Steven Rostedt]

On Tue, 1 Apr 2014 17:35:05 -0700
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Tue, Apr 1, 2014 at 5:01 PM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> >
> > Why would they break tracing? I remember there was a issue with compat
> > calls, are these related to that?
> 
> They "break" tracing by being invisible to syscall tracing. As you
> really should know ;)
> 
> The syscall tracing feature depends on the wrappers that
> SYSCALL_DEFINEx() creates. See the SYSCALL_TRACE_ENTER_EVENT() etc
> crud in <linux/syscalls.h>
> 
> So there's no SYSCALL_METADATA for those system calls that weren't
> created with the proper SYSCALL_DEFINE() wrappers.
> 

Heh, I know that not having the SYSCALL_DEFINEx() wrappers means that
they wont be traced. I must have misunderstood Peter, as I thought he
meant if we added SYSCALL_DEFINEx(), that they would break tracing.

IIRC, the compat calls had some issues with the SYSCALL_DEFINE()
macros, and I was thinking theses functions would have some off the
wall issue as well.

Yeah, adding the SYSCALL_DEFINEx() macros around those functions would
be good for tracing as well.

Glad I understand you two now ;-)

I would have thought my jet lag would be over by now.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/