Re: [GIT PULL] Core block IO bits for 3.15-rc

[Frederic Weisbecker]

On Tue, Apr 01, 2014 at 08:48:48PM -0600, Jens Axboe wrote:
> On 2014-04-01 20:43, Linus Torvalds wrote:
> >On Tue, Apr 1, 2014 at 12:05 PM, Jens Axboe <axboe@xxxxxx> wrote:
> >>
> >>- Cleanup of the IPI usage from the block layer, and associated helper
> >>   code. From Frederic Weisbecker and Jan Kara.
> >
> >So I absolutely *hate* how this was done.
> >
> >Why the hell was it mixed in with the block layer code? It's not even
> >in some clean separate branch, it's just randomly in the middle of the
> >block code, for no obvious reason.
> >
> >I'm pulling it this time, but quite frankly, next time I see this kind
> >of ugly AND TOTALLY POINTLESS layering violation, I will just drop the
> >stupid pull request.
> >
> >If you want to push me cleanups that are to generic code and are in no
> >way specific to the block layer, fine. But I want a separate pull
> >request that is not in any way mixed up with block code.
> >
> >In other words, this was NOT OK. This was stupid and wrong, and
> >violated all sanity. I can see absolutely no reason why that
> >smp_call_function_single_async() renaming and the other cleanups are
> >in the block branch. They are totally separate in every single way.
> >
> >What the hell was going on here?
> 
> I agree, it should have been in its own topic branch. No real
> arguments there. And probably should have been split further, so
> only the block required parts ended up in there, and not eg the
> watchdog parts.

I think that having block and watchdog changes, among many other non-core SMP
changes, in the SMP branch is still unavoidable. If we change a core API,
we must convert the users all along. Of course such peripheral changes should
be strictly limited to these API conversion.

But then the right approach would have been to keep this branch standalone and
deal with conflictings changes like block bits once they are pulled in Linus tree.

Anyway sorry again, I initiated the mistake by making these smp changes on top
of the block bits.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/