Re: [PATCH] phy: don't return error from the stubs

From: Felipe Balbi
Date: Wed Apr 02 2014 - 10:17:20 EST


On Wed, Apr 02, 2014 at 03:25:43PM +0300, Heikki Krogerus wrote:
> Returning 0 from the stubs for the functions that are used
> for PHY controlling. The interface should not appear to be
> failing with every operation when the framework is not
> enabled.
>
> This fixes an issue in dwc3 driver, where the driver fails
> the moment first phy_*() call is made when the framework is
> not enabled.
>
> Reported-by: Chew, Chiau Ee <chiau.ee.chew@xxxxxxxxx>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

Yeah, I'll ack this one because for platforms who really don't need to
SW control a PHY, we need at least *one* way of not depending on it.

Acked-by: Felipe Balbi <balbi@xxxxxx>

--
balbi

Attachment: signature.asc
Description: Digital signature