Re: [PATCH] net: Micrel KSZ8864RMN 4-port managed switch support

[Joe Perches]

On Wed, 2014-04-02 at 17:50 +0200, Philipp Zabel wrote:
> This patch adds support for the Micrel KSZ8864RMN switch to the spi_ks8995
> driver. The KSZ8864RMN switch has a wider 256-byte register space.

trivia:

> diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c
[]
> @@ -317,9 +341,14 @@ static int ks8995_probe(struct spi_device *spi)
>  		goto err_drvdata;
>  	}
>  
> -	dev_info(&spi->dev, "KS89%02X device found, Chip ID:%01x, "
> -			"Revision:%01x\n", ids[0],
> -			get_chip_id(ids[1]), get_chip_rev(ids[1]));
> +	if (get_chip_id(ids[1]) == CHIPID_M) {
> +		dev_info(&spi->dev,
> +			 "KS8995 device found, Chip ID:%01x, Revision:%01x\n",

Using %01x is kind of nonsensical.  %x seems more sensible.

> +			 get_chip_id(ids[1]), get_chip_rev(ids[1]));
> +	} else {
> +		dev_info(&spi->dev, "KSZ8864 device found, Revision:%01x\n",
> +			 get_chip_rev(ids[1]));
> +	}

here too

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/