Re: [PATCH 3.12 03/40] intel_idle: Support Intel Atom Processor C2000 Product Family

[Bockholdt Arne]

> From: Len Brown <len.brown@xxxxxxxxx>
> 
> 3.12-stable review patch.  If anyone has any objections, please let me know.
> 
> ===============
> 
> commit fab04b2208dd1d4121319f0096c5a5f4b70abc54 upstream.
> 
> Support the "Intel(R) Atom(TM) Processor C2000 Product Family",
> formerly code-named Avoton.  It is based on the next generation
> Intel Atom processor architecture, formerly code-named Silvermont.
> 
> Signed-off-by: Len Brown <len.brown@xxxxxxxxx>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> ---
>  drivers/idle/intel_idle.c | 24 +++++++++++++++++++++++-
>  1 file changed, 23 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> index d47bb0f267f7..000d370519d9 100644
> --- a/drivers/idle/intel_idle.c
> +++ b/drivers/idle/intel_idle.c
> @@ -1,7 +1,7 @@
>  /*
>   * intel_idle.c - native hardware idle loop for modern Intel processors
>   *
> - * Copyright (c) 2010, Intel Corporation.
> + * Copyright (c) 2013, Intel Corporation.
>   * Len Brown <len.brown@xxxxxxxxx>
>   *
>   * This program is free software; you can redistribute it and/or modify it
> @@ -329,6 +329,22 @@ static struct cpuidle_state atom_cstates[CPUIDLE_STATE_MAX] = {
>  	{
>  		.enter = NULL }
>  };
> +static struct cpuidle_state avn_cstates[CPUIDLE_STATE_MAX] = {
> +	{
> +		.name = "C1-AVN",
> +		.desc = "MWAIT 0x00",
> +		.flags = MWAIT2flg(0x00) | CPUIDLE_FLAG_TIME_VALID,
> +		.exit_latency = 2,
> +		.target_residency = 2,
> +		.enter = &intel_idle },
> +	{
> +		.name = "C6-AVN",
> +		.desc = "MWAIT 0x51",
> +		.flags = MWAIT2flg(0x58) | CPUIDLE_FLAG_TIME_VALID | CPUIDLE_FLAG_TLB_FLUSHED,
> +		.exit_latency = 15,
> +		.target_residency = 45,
> +		.enter = &intel_idle },
> +};
>  
>  /**
>   * intel_idle
> @@ -465,6 +481,11 @@ static const struct idle_cpu idle_cpu_hsw = {
>  	.disable_promotion_to_c1e = true,
>  };
>  
> +static const struct idle_cpu idle_cpu_avn = {
> +	.state_table = avn_cstates,
> +	.disable_promotion_to_c1e = true,
> +};
> +
>  #define ICPU(model, cpu) \
>  	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_MWAIT, (unsigned long)&cpu }
>  
> @@ -486,6 +507,7 @@ static const struct x86_cpu_id intel_idle_ids[] = {
>  	ICPU(0x3f, idle_cpu_hsw),
>  	ICPU(0x45, idle_cpu_hsw),
>  	ICPU(0x46, idle_cpu_hsw),
> +	ICPU(0x4D, idle_cpu_avn),
>  	{}
>  };
>  MODULE_DEVICE_TABLE(x86cpu, intel_idle_ids);


Ahoj !

For this one you also need the upstream patch
22e580d07f6529a395c129575127ea6d860aed3a to make the C-States  work on
C2000 series.

  Arne


N‹§²æ¸›yú²X¬¶ÇvØ–)Þ{.nlj·¥Š{±‘êX§¶›¡Ü}©ž²ÆzÚj:+v‰¨¾«‘êZ+€Êzf£¢·hšˆ§~†­†Ûÿû®w¥¢¸?™¨è&¢)ßf”ùy§m…á«a¶Úÿ0¶ìå