Re: [PATCH] drivers/staging/vt6655/iwctl.c fix a sparse warning

From: Dan Carpenter
Date: Thu Apr 03 2014 - 05:05:35 EST


On Thu, Mar 27, 2014 at 08:28:44PM -0700, Jimmy Li wrote:
> You are right, I found that variable buf also don't make sense here,
> maybe this could be more clear.
>
> param = kzalloc(sizeof(struct viawget_wpa_param), GFP_KERNEL);
> if (param == NULL)
> return -ENOMEM;
>
> removing two unnecessary variable, buf and blen.
>
> In this situation, I should send a new patch v2 for it base on the
> previous path? or send a new patch include all changes?

We throw away the original patch and you send a v2. Use the subject:

[PATCH v2] drivers/staging/vt6655/iwctl.c fix a sparse warning

Under the Signed-off-by line put:
Signed-off-by: you
---
v2: additional cleanups as well.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/