Re: [PATCH] v3.14-7247-gcd6362b drivers/staging/lustre/lustre/libcfs/workitem.c Fix sparse warning.

From: Dan Carpenter
Date: Thu Apr 03 2014 - 06:30:13 EST


On Thu, Apr 03, 2014 at 08:43:28PM +1100, Mike Sampson wrote:
> Signed-off-by: Mike Sampson <mike@xxxxxxxxxxxxx>
>
> This fixes a sparse warning:
> warning: symbol 'cfs_wi_data' was not declared. Should it be static?
>

Patch is ok. Signed off should go at the end instead of at the start of
the commit message. The subject should be:

[PATCH] Staging: lustre: mark a variable static in workitem.c

Espcially notice how I removed the "v3.14-7247-gcd6362b" and chose a
better prefix. Btw, for these kinds of changes, then you should be
working against -next.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/