Re: [PATCH v2 1/2] usb: doc: udc-xilinx: Add devicetree bindings

[Felipe Balbi]

On Thu, Apr 03, 2014 at 01:05:18PM +0530, Subbaraya Sundeep Bhatta wrote:
> Add devicetree bindings for Xilinx axi udc driver.
> 
> Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xxxxxxxxxx>
> ---
> Changes for v2:
> 	- replaced xlnx,include-dma with xlnx,has-builtin-dma
> 
>  .../devicetree/bindings/usb/udc-xilinx.txt         |   20 ++++++++++++++++++++
>  1 files changed, 20 insertions(+), 0 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/usb/udc-xilinx.txt
> 
> diff --git a/Documentation/devicetree/bindings/usb/udc-xilinx.txt b/Documentation/devicetree/bindings/usb/udc-xilinx.txt
> new file mode 100644
> index 0000000..7c24fac
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/udc-xilinx.txt
> @@ -0,0 +1,20 @@
> +Xilinx AXI USB2 device controller
> +
> +Required properties:
> +- compatible		: Should be "xlnx,axi-usb2-device-4.00.a"
> +- reg			: Physical base address and size of the Axi USB2
> +			  device registers map.
> +- interrupts		: Property with a value describing the interrupt
> +			  number.
> +- interrupt-parent	: Must be core interrupt controller
> +- xlnx,has-builtin-dma	: if DMA is included

isn't there a configuration register to tell you this ?

> +
> +Example:
> + 		axi-usb2-device@42e00000 {
> +                        compatible = "xlnx,axi-usb2-device-4.00.a";
> +                        interrupt-parent = <0x1>;

why isn't interrupt-parent a phandle ?

-- 
balbi

Attachment: signature.asc
Description: Digital signature