Re: [PATCH regression] net: phy: fix initialization (config_init) for Marvel 88E1116R PHYs

From: Alexander Holler
Date: Thu Apr 03 2014 - 11:07:11 EST


Am 03.04.2014 10:49, schrieb Sebastian Hesselbarth:
On 04/03/2014 09:17 AM, Alexander Holler wrote:
Am 03.04.2014 00:27, schrieb Sebastian Hesselbarth:
On 04/03/2014 12:12 AM, Alexander Holler wrote:
I am curious, how you determined above commit to be the cause of the
regression you are seeing. Can you bisect, if you didn't already?

There was no bisecting necessary. I've just looked at what changed in
mv643xx_eth since 3.13 and the first commit I've reverted was already a
hit. Reading a bit source revealed the differences between the old reset
and the newly used one and ended up with my patch (first try) and was a
hit too.

Honestly, your own fix changes a different driver than mv643xx_eth.

It changes stuff which now (through the mentioned commit) gets used
through the change in mv643xx_eth.

Sigh. You have proven youself that the commit isn't the root cause
of the issue you are seeing. Nor is "fixing" 88e1116r init sequence
a reasonable fix.

Sorry, continuing this discussion doesn't make sense. You have the same hw, so just try enabling netconsole with 3.14 and use dhcpcd from userland (this does the final reset here which hangs.

But don't suggest me (or insist on) a time consuming and totally useless bisect when I already know what makes the problem to appear (100% reliable here).

I have better ways to waste my time.

Alexander Holler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/