Re: [PATCH] net: cpts: Add includes for ETH_HLEN and VLAN_HLEN definitions

From: Josh Boyer
Date: Thu Apr 03 2014 - 12:35:24 EST


On Thu, Apr 3, 2014 at 12:32 PM, David Miller <davem@xxxxxxxxxxxxx> wrote:
> From: Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxx>
> Date: Thu, 3 Apr 2014 12:08:43 -0400
>
>> If CONFIG_TI_CPTS is enabled, the ti_cpsw driver will fail to build with:
>>
>> drivers/net/ethernet/ti/cpts.c: In function 'cpts_match':
>> drivers/net/ethernet/ti/cpts.c:266:12: error: 'ETH_HLEN' undeclared (first use in this function)
>> offset = ETH_HLEN + IPV4_HLEN(data) + UDP_HLEN;
>> ^
>> drivers/net/ethernet/ti/cpts.c:266:12: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/net/ethernet/ti/cpts.c:276:23: error: 'VLAN_HLEN' undeclared (first use in this function)
>> offset = ETH_HLEN + VLAN_HLEN;
>> ^
>>
>> Add includes of if_ether.h and if_vlan.h to bring in the appropriate defines.
>>
>> Signed-off-by: Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxx>
>
> A patch for this was already submitted to netdev and applied to the 'net'
> GIT tree earlier today.

Ah, great. Glad it's covered. Thanks.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/