Re: [PATCH v2] drivers/staging/vt6655/iwctl.c fix a sparse warning

From: Dan Carpenter
Date: Thu Apr 03 2014 - 13:42:50 EST


On Fri, Apr 04, 2014 at 12:32:29AM +0800, Jimmy Li wrote:
> Signed-off-by: Jimmy Li <coder.liss@xxxxxxxxx>

You dropped the commit message which said which sparse warnings were
fixed. It should say something about the other cleanups as well. Also
the subject prefix isn't right. Use:

[PATCH v3] Staging: vt6655: iwctl.c: fix a sparse warning

Or something. "drivers/" doesn't add any information.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/