Re: [RFC PATCH] memory driver: make phys_index/end_phys_index reflect the start/end section number

From: KOSAKI Motohiro
Date: Thu Apr 03 2014 - 18:42:21 EST


On Wed, Apr 2, 2014 at 12:09 PM, Dave Hansen <dave.hansen@xxxxxxxxx> wrote:
> On 04/02/2014 01:56 AM, Li Zhong wrote:
>> I noticed the phys_index and end_phys_index under
>> /sys/devices/system/memory/memoryXXX/ have the same value, e.g.
>> (for the test machine, one memory block has 8 sections, that is
>> sections_per_block equals 8)
>>
>> # cd /sys/devices/system/memory/memory100/
>> # cat phys_index end_phys_index
>> 00000064
>> 00000064
>>
>> Seems they should reflect the start/end section number respectively, which
>> also matches what is said in Documentation/memory-hotplug.txt
>
> This changes a user-visible interface. Won't this break userspace?

But who uses this? This is totally broken and I think nobody can use
meaningfully.
I bet we can fix this right now.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/