Re: [PATCHv4 2/2] watchdog: imx2_wdt: convert to use regmap API.

[Guenter Roeck]

On 04/03/2014 06:13 PM, Li.Xiubo@xxxxxxxxxxxxx wrote:
> > > +	base = devm_ioremap_resource(&pdev->dev, res);
> > > +	if (IS_ERR(base))
> > > +		return PTR_ERR(base);
> > > +
> > > +	imx2_wdt.regmap = devm_regmap_init_mmio_clk(&pdev->dev, NULL, base,
> > > +						    &imx2_wdt_regmap_config);
> >
> > This patch causes the following buiild failure:
> >
> > Building arm:imx_v4_v5_defconfig ... failed
> > --------------
> > Error log:
> > drivers/built-in.o: In function `imx2_wdt_probe':
> > clk-composite.c:(.init.text+0x82c4): undefined reference to
> > `devm_regmap_init_mmio_clk'
> > make: *** [vmlinux] Error 1
> > --------------
> >
> > This is on top of
> >
> > b33ce44 Merge branch 'for-3.15/drivers' of git://git.kernel.dk/linux-block
> >
> > Does it have build dependencies on code which is (or was) not yet available
> > in mainline ?
>
> This is caused by not compiling the regmap core.
>
> Could you add the following patch to have a try ?
> ==========================
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 79d2589..3e55fa9 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -369,6 +369,7 @@ config MAX63XX_WATCHDOG
>   config IMX2_WDT
>          tristate "IMX2+ Watchdog"
>          depends on ARCH_MXC
> +       select REGMAP_MMIO
>          help
>            This is the driver for the hardware watchdog
>            on the Freescale IMX2 and later processors.
> --------------------------
>
> If it's okey, I'll sent the v5 series to fix this.
Yes, that fixes the problem.

Guenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/